savecompat.c

Go to the documentation of this file.

/***********************************************************************
 Freeciv - Copyright (C) 1996 - A Kjeldberg, L Gregersen, P Unold
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 2, or (at your option)
   any later version.
 
   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.
***********************************************************************/
 
#ifdef HAVE_CONFIG_H
#include <fc_config.h>
#endif
 
/* utility */
#include "capability.h"
#include "log.h"
 
/* common */
#include "map.h"
#include "specialist.h"
 
/* server */
#include "aiiface.h"
#include "setcompat.h"
#include "settings.h"
#include "unittools.h"
 
#include "savecompat.h"
 
bool sg_success;
 
static char *special_names[] =
  {
    "Irrigation", "Mine", "Pollution", "Hut", "Farmland",
    "Fallout", NULL
  };
 
/*
  For each savefile format after 2.3.0, compatibility functions are defined
  which translate secfile structures from previous version to that version;
  all necessary compat functions are called in order to
  translate between the file and current version. See sg_load_compat().
 
  The integer version ID should be increased every time the format is changed.
  If the change is not backwards compatible, please state the changes in the
  following list and update the compat functions at the end of this file.
 
  - what was added / removed
  - when was it added / removed (date and version)
  - when can additional capability checks be set to mandatory (version)
  - which compatibility checks are needed and till when (version)
 
  freeciv | what                                           | date       | id
  --------+------------------------------------------------+------------+----
  current | (mapped to current savegame format)            | ----/--/-- |  0
          | first version (svn17538)                       | 2010/07/05 |  -
  2.3.0   | 2.3.0 release                                  | 2010/11/?? |  3
  2.4.0   | 2.4.0 release                                  | 201./../.. | 10
          | * player ai type                               |            |
          | * delegation                                   |            |
          | * citizens                                     |            |
          | * save player color                            |            |
          | * "known" info format change                   |            |
  2.5.0   | 2.5.0 release                                  | 201./../.. | 20
  2.6.0   | 2.6.0 release                                  | 201./../.. | 30
  3.0.0   | 3.0.0 release                                  | 201./../.. | 40
  3.1.0   | 3.1.0 release                                  | 201./../.. | 50
  3.2.0   | 3.2.0 release (development)                    | 202./../.. | 60
          |                                                |            |
*/
 
static void compat_load_020400(struct loaddata *loading, enum sgf_version format_class);
static void compat_load_020500(struct loaddata *loading, enum sgf_version format_class);
static void compat_load_020600(struct loaddata *loading, enum sgf_version format_class);
static void compat_load_030000(struct loaddata *loading, enum sgf_version format_class);
static void compat_load_030100(struct loaddata *loading, enum sgf_version format_class);
static void compat_load_030200(struct loaddata *loading, enum sgf_version format_class);
static void compat_post_load_030100(struct loaddata *loading,
                                    enum sgf_version format_class);
 
typedef void (*load_version_func_t) (struct loaddata *loading, enum sgf_version format_class);
 
struct compatibility {
  int version;
  const load_version_func_t load;
  const load_version_func_t post_load;
};
 
/* The struct below contains the information about the savegame versions. It
 * is identified by the version number (first element), which should be
 * steadily increasing. It is saved as 'savefile.version'. The support
 * string (first element of 'name') is not saved in the savegame; it is
 * saved in settings files (so, once assigned, cannot be changed). The
 * 'pretty' string (second element of 'name') can be changed if necessary
 * For changes in the development version, edit the definitions above and
 * add the needed code to load the old version below. Thus, old
 * savegames can still be loaded while the main definition
 * represents the current state of the art. */
/* While developing freeciv 3.2.0, add the compatibility functions to
 * - compat_load_030200 to load old savegame. */
static struct compatibility compat[] = {
  /* dummy; equal to the current version (last element) */
  { 0, NULL, NULL },
  /* version 1 and 2 is not used */
  /* version 3: first savegame2 format, so no compat functions for translation
   * from previous format */
  { 3, NULL, NULL },
  /* version 4 to 9 are reserved for possible changes in 2.3.x */
  { 10, compat_load_020400, NULL },
  /* version 11 to 19 are reserved for possible changes in 2.4.x */
  { 20, compat_load_020500, NULL },
  /* version 21 to 29 are reserved for possible changes in 2.5.x */
  { 30, compat_load_020600, NULL },
  /* version 31 to 39 are reserved for possible changes in 2.6.x */
  { 40, compat_load_030000, NULL },
  /* version 41 to 49 are reserved for possible changes in 3.0.x */
  { 50, compat_load_030100, compat_post_load_030100 },
  /* version 51 to 59 are reserved for possible changes in 3.1.x */
  { 60, compat_load_030200, NULL },
  /* Current savefile version is listed above this line; it corresponds to
     the definitions in this file. */
};
 
static const int compat_num = ARRAY_SIZE(compat);
#define compat_current (compat_num - 1)
 
/************************************************************************/
void sg_load_compat(struct loaddata *loading, enum sgf_version format_class)
{
  int i;
 
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  loading->version = secfile_lookup_int_default(loading->file, -1,
                                                "savefile.version");
#ifdef FREECIV_DEBUG
  sg_failure_ret(0 < loading->version, "Invalid savefile format version (%d).",
                 loading->version);
  if (loading->version > compat[compat_current].version) {
    /* Debug build can (TRY TO!) load newer versions but ... */
    log_error("Savegame version newer than this build found (%d > %d). "
              "Trying to load the game nevertheless ...", loading->version,
              compat[compat_current].version);
  }
#else  /* FREECIV_DEBUG */
  sg_failure_ret(0 < loading->version
                 && loading->version <= compat[compat_current].version,
                 "Unknown savefile format version (%d).", loading->version);
#endif /* FREECIV_DEBUG */
 
 
  for (i = 0; i < compat_num; i++) {
    if (loading->version < compat[i].version && compat[i].load != NULL) {
      log_normal(_("Run compatibility function for version: <%d "
                   "(save file: %d; server: %d)."), compat[i].version,
                 loading->version, compat[compat_current].version);
      compat[i].load(loading, format_class);
    }
  }
}
 
/************************************************************************/
void sg_load_post_load_compat(struct loaddata *loading,
                              enum sgf_version format_class)
{
  int i;
 
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  for (i = 0; i < compat_num; i++) {
    if (loading->version < compat[i].version
        && compat[i].post_load != NULL) {
      log_normal(_("Run post load compatibility function for version: <%d "
                   "(save file: %d; server: %d)."), compat[i].version,
                 loading->version, compat[compat_current].version);
      compat[i].post_load(loading, format_class);
    }
  }
}
 
/************************************************************************/
int current_compat_ver(void)
{
  return compat[compat_current].version;
}
 
/************************************************************************/
char bin2ascii_hex(int value, int halfbyte_wanted)
{
  return hex_chars[((value) >> ((halfbyte_wanted) * 4)) & 0xf];
}
 
/************************************************************************/
int ascii_hex2bin(char ch, int halfbyte)
{
  const char *pch;
 
  if (ch == ' ') {
    /* Sane value. It is unknown if there are savegames out there which
     * need this fix. Savegame.c doesn't write such savegames
     * (anymore) since the inclusion into CVS (2000-08-25). */
    return 0;
  }
 
  pch = strchr(hex_chars, ch);
 
  sg_failure_ret_val(NULL != pch && '\0' != ch, 0,
                     "Unknown hex value: '%c' %d", ch, ch);
  return (pch - hex_chars) << (halfbyte * 4);
}
 
static const char num_chars[] =
  "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_-+";
 
/************************************************************************/
int char2num(char ch)
{
  const char *pch;
 
  pch = strchr(num_chars, ch);
 
  sg_failure_ret_val(NULL != pch, 0,
                     "Unknown ascii value for num: '%c' %d", ch, ch);
 
  return pch - num_chars;
}
 
/************************************************************************/
enum tile_special_type special_by_rule_name(const char *name)
{
  int i;
 
  for (i = 0; special_names[i] != NULL; i++) {
    if (!strcmp(name, special_names[i])) {
      return i;
    }
  }
 
  return S_LAST;
}
 
/************************************************************************/
const char *special_rule_name(enum tile_special_type type)
{
  fc_assert(type >= 0 && type < S_LAST);
 
  return special_names[type];
}
 
/************************************************************************/
struct extra_type *special_extra_get(int spe)
{
  struct extra_type_list *elist = extra_type_list_by_cause(EC_SPECIAL);
 
  if (spe < extra_type_list_size(elist)) {
    return extra_type_list_get(elist, spe);
  }
 
  return NULL;
}
 
/************************************************************************/
struct extra_type *resource_by_identifier(const char identifier)
{
  extra_type_by_cause_iterate(EC_RESOURCE, presource) {
    if (presource->data.resource->id_old_save == identifier) {
      return presource;
    }
  } extra_type_by_cause_iterate_end;
 
  return NULL;
}
 
/* =======================================================================
 * Compatibility functions for loading a game.
 * ======================================================================= */
 
/************************************************************************/
static void compat_load_020400(struct loaddata *loading,
                               enum sgf_version format_class)
{
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  log_debug("Upgrading data from savegame to version 2.4.0");
 
  /* Add the default player AI. */
  player_slots_iterate(pslot) {
    int ncities, i, plrno = player_slot_index(pslot);
 
    if (NULL == secfile_section_lookup(loading->file, "player%d", plrno)) {
      continue;
    }
 
    secfile_insert_str(loading->file, default_ai_type_name(),
                       "player%d.ai_type", player_slot_index(pslot));
 
    /* Create dummy citizens information. We do not know if citizens are
     * activated due to the fact that this information
     * (game.info.citizen_nationality) is not available, but adding the
     * information does no harm. */
    ncities = secfile_lookup_int_default(loading->file, 0,
                                         "player%d.ncities", plrno);
    if (ncities > 0) {
      for (i = 0; i < ncities; i++) {
        int size = secfile_lookup_int_default(loading->file, 0,
                                              "player%d.c%d.size", plrno, i);
        if (size > 0) {
          secfile_insert_int(loading->file, size,
                             "player%d.c%d.citizen%d", plrno, i, plrno);
        }
      }
    }
 
  } player_slots_iterate_end;
 
  /* Player colors are assigned at the end of player loading, as this
   * needs information not available here. */
 
  /* Deal with buggy known tiles information from 2.3.0/2.3.1 (and the
   * workaround in later 2.3.x); see gna bug #19029.
   * (The structure of this code is odd as it avoids relying on knowledge of
   * xsize/ysize, which haven't been extracted from the savefile yet.) */
  {
    if (has_capability("knownv2",
                       secfile_lookup_str(loading->file, "savefile.options"))) {
      /* This savefile contains known information in a sane format.
       * Just move any entries to where 2.4.x+ expect to find them. */
      struct section *map = secfile_section_by_name(loading->file, "map");
 
      if (map != NULL) {
        entry_list_iterate(section_entries(map), pentry) {
          const char *name = entry_name(pentry);
 
          if (!fc_strncmp(name, "kvb", 3)) {
            /* Rename the "kvb..." entry to "k..." */
            char *name2 = fc_strdup(name), *newname = name2 + 2;
 
            *newname = 'k';
            /* Savefile probably contains existing "k" entries, which are bogus
             * so we trash them. */
            secfile_entry_delete(loading->file, "map.%s", newname);
            entry_set_name(pentry, newname);
            FC_FREE(name2);
          }
        } entry_list_iterate_end;
      }
      /* Could remove "knownv2" from savefile.options, but it's doing
       * no harm there. */
    } else {
      /* This savefile only contains known information in the broken
       * format. Try to recover it to a sane format. */
      /* MAX_NUM_PLAYER_SLOTS in 2.3.x was 128 */
      /* MAP_MAX_LINEAR_SIZE in 2.3.x was 512 */
      const int maxslots = 128, maxmapsize = 512;
      const int lines = maxslots/32;
      int xsize = 0, y, l, j, x;
      unsigned int known_row_old[lines * maxmapsize],
                   known_row[lines * maxmapsize];
      /* Process a map row at a time */
      for (y = 0; y < maxmapsize; y++) {
        /* Look for broken info to convert */
        bool found = FALSE;
        memset(known_row_old, 0, sizeof(known_row_old));
        for (l = 0; l < lines; l++) {
          for (j = 0; j < 8; j++) {
            const char *s =
              secfile_lookup_str_default(loading->file, NULL,
                                         "map.k%02d_%04d", l * 8 + j, y);
            if (s) {
              found = TRUE;
              if (xsize == 0) {
                xsize = strlen(s);
              }
              sg_failure_ret(xsize == strlen(s),
                             "Inconsistent xsize in map.k%02d_%04d",
                             l * 8 + j, y);
              for (x = 0; x < xsize; x++) {
                known_row_old[l * xsize + x] |= ascii_hex2bin(s[x], j);
              }
            }
          }
        }
        if (found) {
          /* At least one entry found for this row. Let's hope they were
           * all there. */
          /* Attempt to munge into sane format */
          int p;
          memset(known_row, 0, sizeof(known_row));
          /* Iterate over possible player slots */
          for (p = 0; p < maxslots; p++) {
            l = p / 32;
            for (x = 0; x < xsize; x++) {
              /* This test causes bit-shifts of >=32 (undefined behaviour), but
               * on common platforms, information happens not to be lost, just
               * oddly arranged. */
              if (known_row_old[l * xsize + x] & (1u << (p - l * 8))) {
                known_row[l * xsize + x] |= (1u << (p - l * 32));
              }
            }
          }
          /* Save sane format back to memory representation of secfile for
           * real loading code to pick up */
          for (l = 0; l < lines; l++) {
            for (j = 0; j < 8; j++) {
              /* Save info for all slots (not just used ones). It's only
               * memory, after all. */
              char row[xsize+1];
              for (x = 0; x < xsize; x++) {
                row[x] = bin2ascii_hex(known_row[l * xsize + x], j);
              }
              row[xsize] = '\0';
              secfile_replace_str(loading->file, row,
                                  "map.k%02d_%04d", l * 8 + j, y);
            }
          }
        }
      }
    }
  }
 
  /* Server setting migration. */
  {
    int set_count;
 
    if (secfile_lookup_int(loading->file, &set_count, "settings.set_count")) {
      int i, new_opt = set_count;
      bool gamestart_valid
        = secfile_lookup_bool_default(loading->file, FALSE,
                                      "settings.gamestart_valid");
 
      for (i = 0; i < set_count; i++) {
        const char *name
          = secfile_lookup_str(loading->file, "settings.set%d.name", i);
 
        if (!name) {
          continue;
        }
 
        /* In 2.3.x and prior, saveturns=0 meant no turn-based saves.
         * This is now controlled by the "autosaves" setting. */
        if (!fc_strcasecmp("saveturns", name)) {
          /* XXX: hardcodes details from GAME_AUTOSAVES_DEFAULT
           * and settings.c:autosaves_name() (but these defaults reflect
           * 2.3's behaviour). */
          const char *const nosave = "GAMEOVER|QUITIDLE|INTERRUPT";
          const char *const save = "TURN|GAMEOVER|QUITIDLE|INTERRUPT";
          int nturns;
 
          if (secfile_lookup_int(loading->file, &nturns,
                                 "settings.set%d.value", i)) {
            if (nturns == 0) {
              /* Invent a new "autosaves" setting */
              secfile_insert_str(loading->file, nosave,
                                 "settings.set%d.value", new_opt);
              /* Pick something valid for saveturns */
              secfile_replace_int(loading->file, GAME_DEFAULT_SAVETURNS,
                                  "settings.set%d.value", i);
            } else {
              secfile_insert_str(loading->file, save,
                                 "settings.set%d.value", new_opt);
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
          if (gamestart_valid) {
            if (secfile_lookup_int(loading->file, &nturns,
                                   "settings.set%d.gamestart", i)) {
              if (nturns == 0) {
                /* Invent a new "autosaves" setting */
                secfile_insert_str(loading->file, nosave,
                                   "settings.set%d.gamestart", new_opt);
                /* Pick something valid for saveturns */
                secfile_replace_int(loading->file, GAME_DEFAULT_SAVETURNS,
                                    "settings.set%d.gamestart", i);
              } else {
                secfile_insert_str(loading->file, save,
                                   "settings.set%d.gamestart", new_opt);
              }
            } else {
              log_sg("Setting '%s': %s", name, secfile_error());
            }
          }
        } else if (!fc_strcasecmp("autosaves", name)) {
          /* Sanity check. This won't trigger on an option we've just
           * invented, as the loop won't include it. */
          log_sg("Unexpected \"autosaves\" setting found in pre-2.4 "
                 "savefile. It may have been overridden.");
        }
      }
    }
  }
}
 
/************************************************************************/
static const char *killcitizen_enum_str(secfile_data_t data, int bit)
{
  switch (bit) {
  case UMT_LAND:
    return "LAND";
  case UMT_SEA:
    return "SEA";
  case UMT_BOTH:
    return "BOTH";
  }
 
  return NULL;
}
 
/************************************************************************/
static void compat_load_020500(struct loaddata *loading,
                               enum sgf_version format_class)
{
  const char *modname[] = { "Road", "Railroad" };
  const char *old_activities_names[] = {
    "Idle",
    "Pollution",
    "Unused Road",
    "Mine",
    "Irrigate",
    "Mine",
    "Irrigate",
    "Fortified",
    "Fortress",
    "Sentry",
    "Unused Railroad",
    "Pillage",
    "Goto",
    "Explore",
    "Transform",
    "Unused",
    "Unused Airbase",
    "Fortifying",
    "Fallout",
    "Unused Patrol",
    "Base"
  };
 
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  log_debug("Upgrading data from savegame to version 2.5.0");
 
  secfile_insert_int(loading->file, 2, "savefile.roads_size");
  secfile_insert_int(loading->file, 0, "savefile.trait_size");
 
  secfile_insert_str_vec(loading->file, modname, 2,
                         "savefile.roads_vector");
 
  secfile_insert_int(loading->file, 19, "savefile.activities_size");
  secfile_insert_str_vec(loading->file, old_activities_names, 19,
                         "savefile.activities_vector");
 
  /* Server setting migration. */
  {
    int set_count;
 
    if (secfile_lookup_int(loading->file, &set_count, "settings.set_count")) {
      int i;
      bool gamestart_valid
        = secfile_lookup_bool_default(loading->file, FALSE,
                                      "settings.gamestart_valid");
      for (i = 0; i < set_count; i++) {
        const char *name
          = secfile_lookup_str(loading->file, "settings.set%d.name", i);
        if (!name) {
          continue;
        }
        /* In 2.4.x and prior, "killcitizen" listed move types that
         * killed citizens after successful attack. Now killcitizen
         * is just boolean and classes affected are defined in ruleset. */
        if (!fc_strcasecmp("killcitizen", name)) {
          int value;
 
          if (secfile_lookup_enum_data(loading->file, &value, TRUE,
                                       killcitizen_enum_str, NULL,
                                       "settings.set%d.value", i)) {
            /* Lowest bit of old killcitizen value indicates if
             * land units should kill citizens. We take that as
             * new boolean killcitizen value. */
            if (value & 0x1) {
              secfile_replace_bool(loading->file, TRUE,
                                   "settings.set%d.value", i);
            } else {
              secfile_replace_bool(loading->file, FALSE,
                                   "settings.set%d.value", i);
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
          if (gamestart_valid) {
            if (secfile_lookup_enum_data(loading->file, &value, TRUE,
                                         killcitizen_enum_str, NULL,
                                         "settings.set%d.gamestart", i)) {
              /* Lowest bit of old killcitizen value indicates if
               * land units should kill citizens. We take that as
               * new boolean killcitizen value. */
              if (value & 0x1) {
                secfile_replace_bool(loading->file, TRUE,
                                     "settings.set%d.gamestart", i);
              } else {
                secfile_replace_bool(loading->file, FALSE,
                                     "settings.set%d.gamestart", i);
              }
            } else {
              log_sg("Setting '%s': %s", name, secfile_error());
            }
          }
        }
      }
    }
  }
}
 
/************************************************************************/
static char *revolentype_str(enum revolen_type type)
{
  switch (type) {
  case REVOLEN_FIXED:
    return "FIXED";
  case REVOLEN_RANDOM:
    return "RANDOM";
  case REVOLEN_QUICKENING:
    return "QUICKENING";
  case REVOLEN_RANDQUICK:
    return "RANDQUICK";
  }
 
  return "";
}
 
/************************************************************************/
static void compat_load_020600(struct loaddata *loading,
                               enum sgf_version format_class)
{
  bool team_pooled_research = GAME_DEFAULT_TEAM_POOLED_RESEARCH;
  int tsize;
  int ti;
  int turn;
 
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  log_debug("Upgrading data from savegame to version 2.6.0");
 
  /* Terrain mapping table - use current ruleset as we have no way to know
   * any other old values. */
  ti = 0;
  terrain_type_iterate(pterr) {
    char buf[2];
 
    secfile_insert_str(loading->file, terrain_rule_name(pterr), "savefile.terrident%d.name", ti);
    buf[0] = terrain_identifier(pterr);
    buf[1] = '\0';
    secfile_insert_str(loading->file, buf, "savefile.terrident%d.identifier", ti++);
  } terrain_type_iterate_end;
 
  /* Server setting migration. */
  {
    int set_count;
 
    if (secfile_lookup_int(loading->file, &set_count, "settings.set_count")) {
      char value_buffer[1024] = "";
      char gamestart_buffer[1024] = "";
      int i;
      int dcost = -1;
      int dstartcost = -1;
      enum revolen_type rlt = GAME_DEFAULT_REVOLENTYPE;
      enum revolen_type gsrlt = GAME_DEFAULT_REVOLENTYPE;
      bool gamestart_valid
        = secfile_lookup_bool_default(loading->file, FALSE,
                                      "settings.gamestart_valid");
      int new_set_count;
 
      for (i = 0; i < set_count; i++) {
        const char *name
          = secfile_lookup_str(loading->file, "settings.set%d.name", i);
        if (!name) {
          continue;
        }
 
        /* In 2.5.x and prior, "spacerace" boolean controlled if
         * spacerace victory condition was active. */
        if (!fc_strcasecmp("spacerace", name)) {
          bool value;
 
          if (secfile_lookup_bool(loading->file, &value,
                                  "settings.set%d.value", i)) {
            if (value) {
              if (value_buffer[0] != '\0') {
                sz_strlcat(value_buffer, "|");
              }
              sz_strlcat(value_buffer, "SPACERACE");
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
          if (secfile_lookup_bool(loading->file, &value,
                                  "settings.set%d.gamestart", i)) {
            if (value) {
              if (gamestart_buffer[0] != '\0') {
                sz_strlcat(gamestart_buffer, "|");
              }
              sz_strlcat(gamestart_buffer, "SPACERACE");
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
 
          /* We cannot delete old values from the secfile, or rather cannot
           * change index of the later settings. Renumbering them is not easy as
           * we don't know type of each setting we would encounter.
           * So we keep old setting values and only add new "victories" setting. */
        } else if (!fc_strcasecmp("alliedvictory", name)) {
          bool value;
 
          if (secfile_lookup_bool(loading->file, &value,
                                  "settings.set%d.value", i)) {
            if (value) {
              if (value_buffer[0] != '\0') {
                sz_strlcat(value_buffer, "|");
              }
              sz_strlcat(value_buffer, "ALLIED");
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
          if (secfile_lookup_bool(loading->file, &value,
                                  "settings.set%d.gamestart", i)) {
            if (value) {
              if (gamestart_buffer[0] != '\0') {
                sz_strlcat(gamestart_buffer, "|");
              }
              sz_strlcat(gamestart_buffer, "ALLIED");
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
        } else if (!fc_strcasecmp("revolen", name)) {
          int value;
 
          if (secfile_lookup_int(loading->file, &value,
                                 "settings.set%d.value", i)) {
            /* 0 meant RANDOM 1-5 */
            if (value == 0) {
              rlt = REVOLEN_RANDOM;
              secfile_replace_int(loading->file, 5,
                                  "settings.set%d.value", i);
            } else {
              rlt = REVOLEN_FIXED;
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
          if (secfile_lookup_int(loading->file, &value,
                                 "settings.set%d.gamestart", i)) {
            /* 0 meant RANDOM 1-5 */
            if (value == 0) {
              gsrlt = REVOLEN_RANDOM;
              secfile_replace_int(loading->file, 5,
                                  "settings.set%d.gamestart", i);
            } else {
              gsrlt = REVOLEN_FIXED;
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
        } else if (!fc_strcasecmp("happyborders", name)) {
          bool value;
 
          if (secfile_lookup_bool(loading->file, &value,
                                  "settings.set%d.value", i)) {
            secfile_entry_delete(loading->file, "settings.set%d.value", i);
            if (value) {
              secfile_insert_str(loading->file, "NATIONAL",
                                 "settings.set%d.value", i);
            } else {
              secfile_insert_str(loading->file, "DISABLED",
                                 "settings.set%d.value", i);
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
          if (secfile_lookup_bool(loading->file, &value,
                                  "settings.set%d.gamestart", i)) {
            secfile_entry_delete(loading->file, "settings.set%d.gamestart", i);
            if (value) {
              secfile_insert_str(loading->file, "NATIONAL",
                                 "settings.set%d.gamestart", i);
            } else {
              secfile_insert_str(loading->file, "DISABLED",
                                 "settings.set%d.gamestart", i);
            }
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
        } else if (!fc_strcasecmp("team_pooled_research", name)) {
          sg_warn(secfile_lookup_bool(loading->file,
                                      &team_pooled_research,
                                      "settings.set%d.value", i),
                  "%s", secfile_error());
        } else if (!fc_strcasecmp("diplcost", name)) {
          /* Old 'diplcost' split to 'diplbulbcost' and 'diplgoldcost' */
          if (secfile_lookup_int(loading->file, &dcost,
                                 "settings.set%d.value", i)) {
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
 
          if (secfile_lookup_int(loading->file, &dstartcost,
                                 "settings.set%d.gamestart", i)) {
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
        } else if (!fc_strcasecmp("huts", name)) {
          /* Scale of 'huts' changed. */
          int hcount;
 
          if (secfile_lookup_int(loading->file, &hcount,
                                 "settings.set%d.value", i)) {
          } else {
            log_sg("Setting '%s': %s", name, secfile_error());
          }
 
          /* Store old-style absolute value. */
          wld.map.server.huts_absolute = hcount;
        }
      }
 
      new_set_count = set_count + 2; /* 'victories' and 'revolentype' */
 
      if (dcost >= 0) {
        new_set_count += 2;
      }
 
      secfile_replace_int(loading->file, new_set_count, "settings.set_count");
 
      secfile_insert_str(loading->file, "victories", "settings.set%d.name",
                         set_count);
      secfile_insert_str(loading->file, value_buffer, "settings.set%d.value",
                         set_count);
      secfile_insert_str(loading->file, "revolentype", "settings.set%d.name",
                         set_count + 1);
      secfile_insert_str(loading->file, revolentype_str(rlt), "settings.set%d.value",
                         set_count + 1);
 
      if (dcost >= 0) {
        secfile_insert_str(loading->file, "diplbulbcost", "settings.set%d.name", set_count + 2);
        secfile_insert_int(loading->file, dcost, "settings.set%d.value", set_count + 2);
        secfile_insert_str(loading->file, "diplgoldcost", "settings.set%d.name", set_count + 3);
        secfile_insert_int(loading->file, dcost, "settings.set%d.value", set_count + 3);
      }
 
      if (gamestart_valid) {
        secfile_insert_str(loading->file, gamestart_buffer, "settings.set%d.gamestart",
                           set_count);
        secfile_insert_str(loading->file, revolentype_str(gsrlt), "settings.set%d.gamestart",
                           set_count + 1);
 
        if (dcost >= 0) {
          secfile_insert_int(loading->file, dstartcost, "settings.set%d.gamestart", set_count + 2);
          secfile_insert_int(loading->file, dstartcost, "settings.set%d.gamestart", set_count + 3);
        }
      }
    }
  }
 
  sg_failure_ret(secfile_lookup_int(loading->file, &tsize, "savefile.trait_size"),
                 "Trait size: %s", secfile_error());
 
  turn = secfile_lookup_int_default(loading->file, 0, "game.turn");
 
  player_slots_iterate(pslot) {
    int plrno = player_slot_index(pslot);
    bool got_first_city;
    int old_barb_type;
    enum barbarian_type new_barb_type;
    int i;
    const char *name;
    int score;
    int units_num;
 
    if (NULL == secfile_section_lookup(loading->file, "player%d", plrno)) {
      continue;
    }
 
    /* Renamed 'capital' to 'got_first_city'. */
    if (secfile_lookup_bool(loading->file, &got_first_city, 
                            "player%d.capital", plrno)) {
      secfile_insert_bool(loading->file, got_first_city,
                          "player%d.got_first_city", plrno);
    }
 
    /* Add 'anonymous' qualifiers for user names */
    name = secfile_lookup_str_default(loading->file, "", "player%d.username", plrno);
    secfile_insert_bool(loading->file, (!strcmp(name, ANON_USER_NAME)),
                        "player%d.unassigned_user", plrno);
 
    name = secfile_lookup_str_default(loading->file, "", "player%d.ranked_username", plrno);
    secfile_insert_bool(loading->file, (!strcmp(name, ANON_USER_NAME)),
                        "player%d.unassigned_ranked", plrno);
 
    /* Convert numeric barbarian type to textual */
    old_barb_type = secfile_lookup_int_default(loading->file, 0,
                                               "player%d.ai.is_barbarian", plrno);
    new_barb_type = barb_type_convert(old_barb_type);
    secfile_insert_str(loading->file, barbarian_type_name(new_barb_type),
                       "player%d.ai.barb_type", plrno);
 
    /* Pre-2.6 didn't record when a player was created or died, so we have
     * to assume they lived from the start of the game until last turn */
    secfile_insert_int(loading->file, turn, "player%d.turns_alive", plrno);
 
    /* As if there never has been a war. */
    secfile_insert_int(loading->file, -1, "player%d.last_war", plrno);
 
    /* Assume people were playing until current reload */
    secfile_insert_int(loading->file, 0, "player%d.idle_turns", plrno);
 
    for (i = 0; i < tsize; i++) {
      int val;
 
      val = secfile_lookup_int_default(loading->file, -1, "player%d.trait.val%d",
                                       plrno, i);
      if (val != -1) {
        secfile_insert_int(loading->file, val, "player%d.trait%d.val", plrno, i);
      }
 
      sg_failure_ret(secfile_lookup_int(loading->file, &val,
                                        "player%d.trait.mod%d", plrno, i),
                     "Trait mod: %s", secfile_error());
      secfile_insert_int(loading->file, val, "player%d.trait%d.mod", plrno, i);
    }
 
    score = secfile_lookup_int_default(loading->file, -1,
                                       "player%d.units_built", plrno);
    if (score >= 0) {
      secfile_insert_int(loading->file, score, "score%d.units_built", plrno);
    }
 
    score = secfile_lookup_int_default(loading->file, -1,
                                       "player%d.units_killed", plrno);
    if (score >= 0) {
      secfile_insert_int(loading->file, score, "score%d.units_killed", plrno);
    }
 
    score = secfile_lookup_int_default(loading->file, -1,
                                       "player%d.units_lost", plrno);
    if (score >= 0) {
      secfile_insert_int(loading->file, score, "score%d.units_lost", plrno);
    }
 
    /* Units orders. */
    units_num = secfile_lookup_int_default(loading->file, 0,
                                           "player%d.nunits",
                                           plrno);
 
    for (i = 0; i < units_num; i++) {
      int len;
 
      if (secfile_lookup_bool_default(loading->file, FALSE,
                                      "player%d.u%d.orders_last_move_safe",
                                      plrno, i)) {
        continue;
      }
 
      len = secfile_lookup_int_default(loading->file, 0,
                                       "player%d.u%d.orders_length",
                                       plrno, i);
      if (len > 0) {
        char orders_str[len + 1];
        char *p;
 
        sz_strlcpy(orders_str,
                   secfile_lookup_str_default(loading->file, "",
                                              "player%d.u%d.orders_list",
                                              plrno, i));
        if ((p = strrchr(orders_str, 'm'))
            || (p = strrchr(orders_str, 'M'))) {
          *p = 'x'; /* ORDER_MOVE -> ORDER_ACTION_MOVE */
          secfile_replace_str(loading->file, orders_str,
                              "player%d.u%d.orders_list", plrno, i);
        }
      }
    }
  } player_slots_iterate_end;
 
  /* Add specialist order - loading time order is ok here, as we will use
   * that when we in later part of compatibility conversion use the specialist
   * values */
  secfile_insert_int(loading->file, specialist_count(),
                     "savefile.specialists_size");
  {
    const char **modname;
    int i = 0;
 
    modname = fc_calloc(specialist_count(), sizeof(*modname));
 
    specialist_type_iterate(sp) {
      modname[i++] = specialist_rule_name(specialist_by_number(sp));
    } specialist_type_iterate_end;
 
    secfile_insert_str_vec(loading->file, modname, specialist_count(),
                           "savefile.specialists_vector");
 
    free(modname);
  }
 
  /* Replace all city specialist count fields with correct names */
  player_slots_iterate(pslot) {
    int plrno = player_slot_index(pslot);
    int ncities;
    int i;
 
    if (NULL == secfile_section_lookup(loading->file, "player%d", plrno)) {
      continue;
    }
 
    ncities = secfile_lookup_int_default(loading->file, 0, "player%d.ncities", plrno);
 
    for (i = 0; i < ncities; i++) {
      int k = 0;
 
      specialist_type_iterate(sp) {
        struct specialist *psp = specialist_by_number(sp);
        int count;
 
        sg_failure_ret(secfile_lookup_int(loading->file, &count,
                                          "player%d.c%d.n%s",
                                          plrno, i, specialist_rule_name(psp)),
                       "specialist error: %s", secfile_error());
        secfile_entry_delete(loading->file, "player%d.c%d.n%s",
                             plrno, i, specialist_rule_name(psp));
        secfile_insert_int(loading->file, count, "player%d.c%d.nspe%d",
                           plrno, i, k++);
      } specialist_type_iterate_end;
    }
  } player_slots_iterate_end;
 
  /* Build [research]. */
  {
    const struct {
      const char *name;
      enum entry_type type;
    } entries[] = {
      { "goal_name", ENTRY_STR },
      { "techs", ENTRY_INT },
      { "futuretech", ENTRY_INT },
      { "bulbs_before", ENTRY_INT },
      { "saved_name", ENTRY_STR },
      { "bulbs", ENTRY_INT },
      { "now_name", ENTRY_STR },
      { "got_tech", ENTRY_BOOL },
      { "done", ENTRY_STR }
    };
 
    int researches[MAX(player_slot_count(), team_slot_count())];
    int count = 0;
    int i;
 
    for (i = 0; i < ARRAY_SIZE(researches); i++) {
      researches[i] = -1;
    }
 
    player_slots_iterate(pslot) {
      int plrno = player_slot_index(pslot);
      int ival;
      bool bval;
      const char *sval;
      int j;
 
      if (secfile_section_lookup(loading->file, "player%d", plrno) == NULL) {
        continue;
      }
 
      /* Get the research number. */
      if (team_pooled_research) {
        i = secfile_lookup_int_default(loading->file, plrno,
                                       "player%d.team_no", plrno);
      } else {
        i = plrno;
      }
 
      sg_failure_ret(i >= 0 && i < ARRAY_SIZE(researches),
                     "Research out of bounds (%d)!", i);
 
      /* Find the index in [research] section. */
      if (researches[i] == -1) {
        /* This is the first player for this research. */
        secfile_insert_int(loading->file, i, "research.r%d.number", count);
        researches[i] = count;
        count++;
      }
      i = researches[i];
 
      /* Move entries. */
      for (j = 0; j < ARRAY_SIZE(entries); j++) {
        switch (entries[j].type) {
        case ENTRY_BOOL:
          if (secfile_lookup_bool(loading->file, &bval,
                                  "player%d.research.%s",
                                  plrno, entries[j].name)) {
            secfile_insert_bool(loading->file, bval, "research.r%d.%s",
                                i, entries[j].name);
          }
          break;
        case ENTRY_INT:
          if (secfile_lookup_int(loading->file, &ival,
                                 "player%d.research.%s",
                                 plrno, entries[j].name)) {
            secfile_insert_int(loading->file, ival, "research.r%d.%s",
                               i, entries[j].name);
          }
          break;
        case ENTRY_STR:
          if ((sval = secfile_lookup_str(loading->file,
                                         "player%d.research.%s",
                                         plrno, entries[j].name))) {
            secfile_insert_str(loading->file, sval, "research.r%d.%s",
                               i, entries[j].name);
          }
          break;
        case ENTRY_FLOAT:
          sg_failure_ret(entries[j].type != ENTRY_FLOAT,
                         "Research related entry marked as float.");
          break;
        case ENTRY_FILEREFERENCE:
          fc_assert(entries[j].type != ENTRY_FILEREFERENCE);
          break;
        case ENTRY_LONG_COMMENT:
          fc_assert(entries[j].type != ENTRY_LONG_COMMENT);
          break;
        case ENTRY_ILLEGAL:
          fc_assert(entries[j].type != ENTRY_ILLEGAL);
          break;
        }
      }
    } player_slots_iterate_end;
    secfile_insert_int(loading->file, count, "research.count");
  }
 
  /* Add diplstate type order. */
  secfile_insert_int(loading->file, DS_LAST,
                     "savefile.diplstate_type_size");
  if (DS_LAST > 0) {
    const char **modname;
    int i;
    int j;
 
    i = 0;
    modname = fc_calloc(DS_LAST, sizeof(*modname));
 
    for (j = 0; j < DS_LAST; j++) {
      modname[i++] = diplstate_type_name(j);
    }
 
    secfile_insert_str_vec(loading->file, modname,
                           DS_LAST,
                           "savefile.diplstate_type_vector");
    free(modname);
  }
 
  /* Fix save games from Freeciv versions with a bug that made it view
   * "Never met" as closer than "Peace" or "Alliance". */
  player_slots_iterate(pslot) {
    int plrno = player_slot_index(pslot);
 
    if (NULL == secfile_section_lookup(loading->file, "player%d", plrno)) {
      continue;
    }
 
    player_slots_iterate(pslot2) {
      int i = player_slot_index(pslot2);
      char buf[32];
      int current;
      int closest;
 
      if (NULL == secfile_section_lookup(loading->file, "player%d", i)) {
        continue;
      }
 
      fc_snprintf(buf, sizeof(buf), "player%d.diplstate%d", plrno, i);
 
      /* Read the current diplomatic state. */
      current = secfile_lookup_int_default(loading->file, DS_NO_CONTACT,
                                           "%s.type",
                                           buf);
 
      /* Read the closest diplomatic state. */
      closest = secfile_lookup_int_default(loading->file, DS_NO_CONTACT,
                                           "%s.max_state",
                                           buf);
 
      if (closest == DS_NO_CONTACT
          && (current == DS_PEACE
              || current == DS_ALLIANCE)) {
        const char *name1 = secfile_lookup_str_default(loading->file, "",
                                                       "player%d.name", plrno);
        const char *name2 = secfile_lookup_str_default(loading->file, "",
                                                       "player%d.name", i);
        /* The current relationship is closer than what the save game
         * claims is the closes relationship ever. */
 
        log_sg(_("The save game is wrong about what the closest"
                 " relationship %s (player %d) and %s (player %d) have had is."
                 " Fixing it..."),
               name1, plrno, name2, i);
 
        secfile_replace_int(loading->file, current, "%s.max_state", buf);
      }
    } player_slots_iterate_end;
  } player_slots_iterate_end;
}
 
/************************************************************************/
static int increase_secfile_turn_int(struct loaddata *loading, const char *key,
                                     int old_def, bool keep_default)
{
  int value;
 
  value = secfile_lookup_int_default(loading->file, old_def, "%s", key);
 
  if (value != old_def || !keep_default) {
    value++;
    secfile_replace_int(loading->file, value, "%s", key);
  }
 
  return value;
}
 
/************************************************************************/
static void compat_load_030000(struct loaddata *loading,
                               enum sgf_version format_class)
{
  bool randsaved;
  int num_settings;
  bool started;
  int old_turn;
  int event_count;
  int i;
 
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  log_debug("Upgrading data from savegame to version 3.0.0");
 
  /* Rename "random.save" as "random.saved"
   * Note that it's not an error if a scenario does not have [random] at all. */
  if (secfile_lookup_bool(loading->file, &randsaved, "random.save")) {
    secfile_insert_bool(loading->file, randsaved, "random.saved");
  }
 
  /* Already started games should have their turn counts increased by 1 */
  if (secfile_lookup_bool_default(loading->file, TRUE, "game.save_players")) {
    started = TRUE;
 
    old_turn = increase_secfile_turn_int(loading, "game.turn", 0, FALSE) - 1;
    increase_secfile_turn_int(loading, "game.scoreturn", old_turn + GAME_DEFAULT_SCORETURN, FALSE);
    increase_secfile_turn_int(loading, "history.turn", -2, TRUE);
  } else {
    started = FALSE;
  }
 
  player_slots_iterate(pslot) {
    int plrno = player_slot_index(pslot);
    const char *flag_names[1];
 
    if (secfile_section_lookup(loading->file, "player%d", plrno) == NULL) {
      continue;
    }
 
    if (secfile_lookup_bool_default(loading->file, FALSE, "player%d.ai.control",
                                    plrno)) {
      flag_names[0] = plr_flag_id_name(PLRF_AI);
 
      secfile_insert_str_vec(loading->file, flag_names, 1,
                             "player%d.flags", plrno);
    }
 
    if (started) {
      int num = secfile_lookup_int_default(loading->file, 0,
                                           "player%d.nunits",
                                           plrno);
 
      for (i = 0; i < num; i++) {
        char buf[64];
 
        fc_snprintf(buf, sizeof(buf), "player%d.u%d.born", plrno, i);
 
        increase_secfile_turn_int(loading, buf, old_turn, FALSE);
      }
 
      num = secfile_lookup_int_default(loading->file, 0,
                                       "player%d.ncities", plrno);
 
      for (i = 0; i < num; i++) {
        char buf[64];
 
        fc_snprintf(buf, sizeof(buf), "player%d.c%d.turn_founded", plrno, i);
 
        increase_secfile_turn_int(loading, buf, -2, TRUE);
      }
    }
  } player_slots_iterate_end;
 
  /* Settings */
  num_settings = secfile_lookup_int_default(loading->file, 0,
                                            "settings.set_count");
 
  /* User meta server message is now a setting. */
  if (secfile_lookup_bool_default(loading->file, FALSE,
                                  "game.meta_usermessage")) {
    const char *metamessage;
 
    metamessage = secfile_lookup_str_default(loading->file, "",
                                             "game.meta_message");
 
    /* Insert the meta message as a setting */
    secfile_insert_str(loading->file, "metamessage",
                       "settings.set%d.name", num_settings);
    secfile_insert_str(loading->file, metamessage,
                       "settings.set%d.value", num_settings);
    secfile_insert_str(loading->file, "",
                       "settings.set%d.gamestart", num_settings);
    num_settings++;
  }
 
  secfile_replace_int(loading->file, num_settings, "settings.set_count");
 
  event_count = secfile_lookup_int_default(loading->file, 0, "event_cache.count");
 
  for (i = 0; i < event_count; i++) {
    const char *etype;
 
    etype = secfile_lookup_str(loading->file, "event_cache.events%d.event", i);
 
    if (etype != NULL && !fc_strcasecmp("E_UNIT_WIN", etype)) {
      secfile_replace_str(loading->file, "E_UNIT_WIN_DEF",
                          "event_cache.events%d.event", i);
    }
  }
}
 
/************************************************************************/
static void insert_server_side_agent(struct loaddata *loading,
                                     enum sgf_version format_class)
{
  int ssa_size;
 
  if (format_class == SAVEGAME_2) {
    /* Handled in savegame2 */
    return;
  }
 
  ssa_size = secfile_lookup_int_default(loading->file, 0,
                                        "savefile.server_side_agent_size");
 
  if (ssa_size != 0) {
    /* Already inserted. */
    return;
  }
 
  /* Add server side agent order. */
  secfile_insert_int(loading->file, SSA_COUNT,
                     "savefile.server_side_agent_size");
  if (SSA_COUNT > 0) {
    const char **modname;
    int i;
    int j;
 
    i = 0;
    modname = fc_calloc(SSA_COUNT, sizeof(*modname));
 
    for (j = 0; j < SSA_COUNT; j++) {
      modname[i++] = server_side_agent_name(j);
    }
 
    secfile_insert_str_vec(loading->file, modname,
                           SSA_COUNT,
                           "savefile.server_side_agent_list");
    free(modname);
  }
 
  /* Insert server_side_agent unit field. */
  player_slots_iterate(pslot) {
    int unit;
    int units_num;
    int plrno = player_slot_index(pslot);
 
    if (secfile_section_lookup(loading->file, "player%d", plrno)
        == NULL) {
      continue;
    }
 
    /* Number of units the player has. */
    units_num = secfile_lookup_int_default(loading->file, 0,
                                           "player%d.nunits",
                                           plrno);
 
    for (unit = 0; unit < units_num; unit++) {
      bool ai;
 
      if (secfile_section_lookup(loading->file,
                                 "player%d.u%d.server_side_agent",
                                 plrno, unit)
          != NULL) {
        /* Already updated? */
        continue;
      }
 
      ai = secfile_lookup_bool_default(loading->file, FALSE,
                                       "player%d.u%d.ai",
                                       plrno, unit);
 
      if (ai) {
        /* Autosettler and Autoexplore are separated by
         * compat_post_load_030100() when set to SSA_AUTOSETTLER */
        secfile_insert_int(loading->file, SSA_AUTOSETTLER,
                           "player%d.u%d.server_side_agent",
                           plrno, unit);
      } else {
        secfile_insert_int(loading->file, SSA_NONE,
                           "player%d.u%d.server_side_agent",
                           plrno, unit);
      }
    }
  } player_slots_iterate_end;
}
 
/************************************************************************/
static void compat_load_030100(struct loaddata *loading,
                               enum sgf_version format_class)
{
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  log_debug("Upgrading data from savegame to version 3.1.0");
 
  /* Actions are now stored by number. */
  player_slots_iterate(pslot) {
    int unit;
    int units_num;
    int plrno = player_slot_index(pslot);
 
    if (secfile_section_lookup(loading->file, "player%d", plrno)
        == NULL) {
      continue;
    }
 
    /* Number of units the player has. */
    units_num = secfile_lookup_int_default(loading->file, 0,
                                           "player%d.nunits",
                                           plrno);
 
    for (unit = 0; unit < units_num; unit++) {
      const char *action_unitstr;
      int order_len;
 
      order_len = secfile_lookup_int_default(loading->file, 0,
                                             "player%d.u%d.orders_length",
                                             plrno, unit);
 
      if ((action_unitstr = secfile_lookup_str_default(loading->file, "",
                                                       "player%d.u%d.action_list",
                                                       plrno, unit))) {
        int order_num;
 
        if (order_len > strlen(action_unitstr)) {
          order_len = strlen(action_unitstr);
        }
 
        for (order_num = 0; order_num < order_len; order_num++) {
          int unconverted_action_id;
 
          if (action_unitstr[order_num] == '?') {
            unconverted_action_id = -1;
          } else {
            unconverted_action_id = char2num(action_unitstr[order_num]);
          }
 
          if (order_num == 0) {
            /* The start of a vector has no number. */
            secfile_insert_int(loading->file, unconverted_action_id,
                               "player%d.u%d.action_vec",
                               plrno, unit);
          } else {
            secfile_insert_int(loading->file, unconverted_action_id,
                               "player%d.u%d.action_vec,%d",
                               plrno, unit, order_num);
          }
        }
      }
    }
  } player_slots_iterate_end;
 
  {
    int action_count;
 
    action_count = secfile_lookup_int_default(loading->file, 0,
                                              "savefile.action_size");
 
    if (action_count > 0) {
      const char **modname;
      const char **savemod;
      int j;
      const char *dur_name = "Disband Unit Recover";
 
      modname = secfile_lookup_str_vec(loading->file, &loading->action.size,
                                       "savefile.action_vector");
 
      savemod = fc_calloc(action_count, sizeof(*savemod));
 
      for (j = 0; j < action_count; j++) {
        if (!fc_strcasecmp("Recycle Unit", modname[j])) {
          savemod[j] = dur_name;
        } else {
          savemod[j] = modname[j];
        }
      }
 
      secfile_replace_str_vec(loading->file, savemod, action_count,
                              "savefile.action_vector");
 
      free(savemod);
    }
  }
 
  /* Server setting migration. */
  {
    int set_count;
 
    if (secfile_lookup_int(loading->file, &set_count, "settings.set_count")) {
      int i;
      bool gamestart_valid
        = secfile_lookup_bool_default(loading->file, FALSE,
                                      "settings.gamestart_valid");
 
      /* Only add gamesetdef if gamestart is valid at all */
      if (gamestart_valid) {
        for (i = 0; i < set_count; i++) {
          const char *name
            = secfile_lookup_str(loading->file, "settings.set%d.name", i);
 
          if (!name) {
            continue;
          }
 
          secfile_insert_str(loading->file, setting_default_level_name(SETDEF_CHANGED),
                             "settings.set%d.gamesetdef", i);
        }
      }
    }
  }
 
  /* Explicit server side agent was new in 3.1 */
  insert_server_side_agent(loading, format_class);
}
 
/************************************************************************/
static void unit_order_activity_to_action(struct unit *act_unit)
{
  int i;
 
  for (i = 0; i < act_unit->orders.length; i++) {
    struct unit_order *order = &act_unit->orders.list[i];
 
    if (order->order != ORDER_ACTIVITY) {
      continue;
    }
 
    switch (order->activity) {
    case ACTIVITY_CLEAN:
    case ACTIVITY_MINE:
    case ACTIVITY_IRRIGATE:
    case ACTIVITY_PLANT:
    case ACTIVITY_CULTIVATE:
    case ACTIVITY_TRANSFORM:
    case ACTIVITY_CONVERT:
    case ACTIVITY_FORTIFYING:
    case ACTIVITY_BASE:
    case ACTIVITY_GEN_ROAD:
    case ACTIVITY_PILLAGE:
      action_iterate(act_id) {
        struct action *paction = action_by_number(act_id);
 
        if (action_get_activity(paction) == order->activity) {
          order->order = ORDER_PERFORM_ACTION;
          order->action = action_number(paction);
          order->activity = ACTIVITY_LAST;
          break;
        }
      } action_iterate_end;
      break;
    case ACTIVITY_SENTRY:
      /* Not an action */
      break;
    case ACTIVITY_EXPLORE:
    case ACTIVITY_IDLE:
    case ACTIVITY_GOTO:
    case ACTIVITY_FORTIFIED:
    case ACTIVITY_LAST:
      log_error("Activity %d is not supposed to appear in unit orders",
                order->activity);
      break;
    }
  }
}
 
/************************************************************************/
static enum direction8 dir_opposite(enum direction8 dir)
{
  switch (dir) {
  case DIR8_NORTH:
    return DIR8_SOUTH;
  case DIR8_NORTHEAST:
    return DIR8_SOUTHWEST;
  case DIR8_EAST:
    return DIR8_WEST;
  case DIR8_SOUTHEAST:
    return DIR8_NORTHWEST;
  case DIR8_SOUTH:
    return DIR8_NORTH;
  case DIR8_SOUTHWEST:
    return DIR8_NORTHEAST;
  case DIR8_WEST:
    return DIR8_EAST;
  case DIR8_NORTHWEST:
    return DIR8_SOUTHEAST;
  }
 
  return DIR8_ORIGIN;
}
 
/************************************************************************/
static void upgrade_unit_order_targets(struct unit *act_unit)
{
  int i;
  struct tile *current_tile;
  struct tile *tgt_tile;
 
  if (!unit_has_orders(act_unit)) {
    return;
  }
 
  /* The order index is for the unit at its current tile. */
  current_tile = unit_tile(act_unit);
 
  /* Rewind to the beginning of the orders */
  for (i = act_unit->orders.index; i > 0 && current_tile != NULL; i--) {
    struct unit_order *prev_order = &act_unit->orders.list[i - 1];
 
    if (!(prev_order->order == ORDER_PERFORM_ACTION
          && utype_is_unmoved_by_action(action_by_number(prev_order->action),
                                        unit_type_get(act_unit)))
        && direction8_is_valid(prev_order->dir)) {
      current_tile = mapstep(&(wld.map), current_tile,
                             dir_opposite(prev_order->dir));
    }
  }
 
  /* Upgrade to explicit target tile */
  for (i = 0; i < act_unit->orders.length && current_tile != NULL; i++) {
    struct unit_order *order = &act_unit->orders.list[i];
 
    if (order->order == ORDER_PERFORM_ACTION
        && order->target != NO_TARGET) {
      /* The target is already specified in the new format. */
 
      /* The index_to_tile() call has no side-effects that we
       * would want also in NDEBUG builds. */
      fc_assert(index_to_tile(&(wld.map), order->target) != NULL);
      return;
    }
 
    if (!direction8_is_valid(order->dir)) {
      /* The target of the action is on the actor's tile. */
      tgt_tile = current_tile;
    } else {
      /* The target of the action is on a tile next to the actor. */
      tgt_tile = mapstep(&(wld.map), current_tile, order->dir);
    }
 
    if (order->order == ORDER_PERFORM_ACTION) {
      if (tgt_tile != NULL) {
        struct action *paction = action_by_number(order->action);
 
        order->target = tgt_tile->index;
        /* Leave no traces. */
        order->dir = DIR8_ORIGIN;
 
        if (!utype_is_unmoved_by_action(paction, unit_type_get(act_unit))) {
          /* The action moves the unit to the target tile (unless this is the
           * final order) */
          fc_assert(utype_is_moved_to_tgt_by_action(paction,
                                                    unit_type_get(act_unit))
                    || i == act_unit->orders.length - 1);
          current_tile = tgt_tile;
        }
      } else {
        current_tile = NULL;
      }
    } else {
      current_tile = tgt_tile;
    }
  }
 
  if (current_tile == NULL) {
    log_sg("Illegal orders for %s. Cancelling.", unit_rule_name(act_unit));
    free_unit_orders(act_unit);
  }
}
 
/************************************************************************/
static void upgrade_server_side_agent(struct loaddata *loading)
{
  players_iterate_alive(pplayer) {
    unit_list_iterate(pplayer->units, punit) {
      if (punit->activity == ACTIVITY_EXPLORE) {
        punit->ssa_controller = SSA_AUTOEXPLORE;
      }
    } unit_list_iterate_end;
  } players_iterate_alive_end;
}
 
/************************************************************************/
static void compat_post_load_030100(struct loaddata *loading,
                                    enum sgf_version format_class)
{
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  /* Action orders were new in 3.0 */
  if (format_class == SAVEGAME_3) {
    /* Only 3.0 savegames may have "Attack" action orders. */
    players_iterate_alive(pplayer) {
      unit_list_iterate(pplayer->units, punit) {
        int i;
 
        if (!punit->has_orders) {
          continue;
        }
 
        fc_assert_action(punit->orders.length == 0
                         || punit->orders.list != NULL, continue);
 
        for (i = 0; i < punit->orders.length; i++) {
          /* "Attack" was split in "Suicide Attack" and "Attack" in 3.1. */
          if (punit->orders.list[i].order == ORDER_PERFORM_ACTION
              && punit->orders.list[i].action == ACTION_ATTACK
              && !unit_can_do_action(punit, ACTION_ATTACK)
              && unit_can_do_action(punit, ACTION_SUICIDE_ATTACK)) {
            punit->orders.list[i].action = ACTION_SUICIDE_ATTACK;
          }
 
          /* Production targeted actions were split from building targeted
           * actions in 3.1. The building sub target encoding changed. */
          if (punit->orders.list[i].order == ORDER_PERFORM_ACTION
              && ((punit->orders.list[i].action
                   == ACTION_SPY_TARGETED_SABOTAGE_CITY)
                  || (punit->orders.list[i].action
                      == ACTION_SPY_TARGETED_SABOTAGE_CITY_ESC))) {
            punit->orders.list[i].sub_target -= 1;
          }
          if (punit->orders.list[i].order == ORDER_PERFORM_ACTION
              && (punit->orders.list[i].action
                  == ACTION_SPY_TARGETED_SABOTAGE_CITY)
              && punit->orders.list[i].sub_target == -1) {
            punit->orders.list[i].action
                = ACTION_SPY_SABOTAGE_CITY_PRODUCTION;
          }
          if (punit->orders.list[i].order == ORDER_PERFORM_ACTION
              && (punit->orders.list[i].action
                  == ACTION_SPY_TARGETED_SABOTAGE_CITY_ESC)
              && punit->orders.list[i].sub_target == -1) {
            punit->orders.list[i].action
                = ACTION_SPY_SABOTAGE_CITY_PRODUCTION_ESC;
          }
        }
      } unit_list_iterate_end;
    } players_iterate_alive_end;
  }
 
  /* Explicit server side agent was new in 3.1 */
  upgrade_server_side_agent(loading);
 
  /* Some activities should only be ordered in action orders. */
  players_iterate_alive(pplayer) {
    unit_list_iterate(pplayer->units, punit) {
      unit_order_activity_to_action(punit);
    } unit_list_iterate_end;
  } players_iterate_alive_end;
 
  /* Unit order action target isn't dir anymore */
  players_iterate_alive(pplayer) {
    unit_list_iterate(pplayer->units, punit) {
      upgrade_unit_order_targets(punit);
    } unit_list_iterate_end;
  } players_iterate_alive_end;
 
  /* Backward compatibility: if we had any open-ended orders (pillage)
   * in the savegame, assign specific targets now */
  players_iterate_alive(pplayer) {
    unit_list_iterate(pplayer->units, punit) {
      unit_assign_specific_activity_target(punit,
                                           &punit->activity,
                                           &punit->activity_target);
    } unit_list_iterate_end;
  } players_iterate_alive_end;
}
 
/************************************************************************/
static void compat_load_030200(struct loaddata *loading,
                               enum sgf_version format_class)
{
  int i;
  int count;
  int set_count;
  bool gamestart_valid = FALSE;
 
  /* Check status and return if not OK (sg_success FALSE). */
  sg_check_ret();
 
  log_debug("Upgrading data from savegame to version 3.2.0");
 
  {
    const char *str = secfile_lookup_str_default(loading->file, NULL,
                                                 "savefile.orig_version");
 
    if (str == NULL) {
      /* Make sure CURRENTLY running version does not
       * end as orig_version when we resave. */
      if (format_class == SAVEGAME_3) {
        secfile_insert_str(loading->file, "old savegame3, or older",
                           "savefile.orig_version");
      } else {
        fc_assert(format_class == SAVEGAME_2);
 
        secfile_insert_str(loading->file, "savegame2, or older",
                           "savefile.orig_version");
      }
    }
  }
 
  {
    int action_count;
 
    action_count = secfile_lookup_int_default(loading->file, 0,
                                              "savefile.action_size");
 
    if (action_count > 0) {
      const char **modname;
      const char **savemod;
      int j;
      const char *dur_name = "Transport Deboard";
      const char *clean_name = "Clean";
 
      modname = secfile_lookup_str_vec(loading->file, &loading->action.size,
                                       "savefile.action_vector");
 
      savemod = fc_calloc(action_count, sizeof(*savemod));
 
      for (j = 0; j < action_count; j++) {
        if (!fc_strcasecmp("Transport Alight", modname[j])) {
          savemod[j] = dur_name;
        } else if (!fc_strcasecmp("Clean Pollution", modname[j])
                   || !fc_strcasecmp("Clean Fallout", modname[j])) {
          savemod[j] = clean_name;
        } else {
          savemod[j] = modname[j];
        }
      }
 
      secfile_replace_str_vec(loading->file, savemod, action_count,
                              "savefile.action_vector");
 
      free(savemod);
    }
  }
 
  {
    int activities_count;
 
    activities_count = secfile_lookup_int_default(loading->file, 0,
                                                  "savefile.activities_size");
 
    if (activities_count > 0) {
      const char **modname;
      const char **savemod;
      int j;
      const char *clean_name = "Clean";
 
      modname = secfile_lookup_str_vec(loading->file, &loading->activities.size,
                                       "savefile.activities_vector");
 
      savemod = fc_calloc(activities_count, sizeof(*savemod));
 
      for (j = 0; j < activities_count; j++) {
        if (!fc_strcasecmp("Pollution", modname[j])
            || !fc_strcasecmp("Fallout", modname[j])) {
          savemod[j] = clean_name;
        } else {
          savemod[j] = modname[j];
        }
      }
 
      secfile_replace_str_vec(loading->file, savemod, activities_count,
                              "savefile.activities_vector");
 
      free(savemod);
    }
  }
 
  /* Server setting migration. */
  {
    if (secfile_lookup_int(loading->file, &set_count, "settings.set_count")) {
      int alltemperate_idx = -1, singlepole_idx = -1;
      bool count_changed = FALSE;
 
      gamestart_valid
        = secfile_lookup_bool_default(loading->file, FALSE,
                                      "settings.gamestart_valid");
 
      for (i = 0; i < set_count; i++) {
        const char *old_name
          = secfile_lookup_str(loading->file, "settings.set%d.name", i);
        const char *name;
 
        if (!old_name) {
          continue;
        }
 
        name = setcompat_S3_2_name_from_S3_1(old_name);
 
        if (fc_strcasecmp(old_name, name)) {
          /* Setting's name changed */
          secfile_replace_str(loading->file, name, "settings.set%d.name", i);
        }
 
        if (!gamestart_valid) {
          /* Older savegames saved these values even when they were not valid.
           * Silence warnings caused by them. */
          (void) secfile_entry_lookup(loading->file, "settings.set%d.gamestart", i);
          (void) secfile_entry_lookup(loading->file, "settings.set%d.gamesetdef", i);
        }
 
        if (!fc_strcasecmp("compresstype", name)) {
          const char *val = secfile_lookup_str(loading->file,
                                               "settings.set%d.value", i);
          if (!fc_strcasecmp(val, "BZIP2")) {
#ifdef FREECIV_HAVE_LIBZSTD
            secfile_replace_str(loading->file, "ZSTD",
                                "settings.set%d.value", i);
#elif FREECIV_HAVE_LIBLZMA
            secfile_replace_str(loading->file, "XZ",
                                "settings.set%d.value", i);
#elif FREECIV_HAVE_LIBZ
            secfile_replace_str(loading->file, "LIBZ",
                                "settings.set%d.value", i);
#else
            secfile_replace_str(loading->file, "PLAIN",
                                "settings.set%d.value", i);
#endif
          }
 
          if (gamestart_valid) {
            val = secfile_lookup_str(loading->file,
                                     "settings.set%d.gamestart", i);
            if (!fc_strcasecmp(val, "BZIP2")) {
#ifdef FREECIV_HAVE_LIBZSTD
              secfile_replace_str(loading->file, "ZSTD",
                                  "settings.set%d.gamestart", i);
#elif FREECIV_HAVE_LIBLZMA
              secfile_replace_str(loading->file, "XZ",
                                  "settings.set%d.gamestart", i);
#elif FREECIV_HAVE_LIBZ
              secfile_replace_str(loading->file, "LIBZ",
                                  "settings.set%d.gamestart", i);
#else
              secfile_replace_str(loading->file, "PLAIN",
                                  "settings.set%d.gamestart", i);
#endif
            }
          }
        } else if (!fc_strcasecmp("topology", name)) {
          struct setting *pset = setting_by_name(name);
          struct sf_cb_data info = { pset, TRUE };
          int val;
 
          if (secfile_lookup_enum_data(loading->file, &val, TRUE,
                                       setting_bitwise_secfile_str, &info,
                                       "settings.set%d.value", i)) {
            char wrap[100];
            char buf[100];
 
            if (val & TF_OLD_WRAPX) {
              if (val & TF_OLD_WRAPY) {
                fc_strlcpy(wrap, "WrapX|WrapY", sizeof(wrap));
              } else {
                fc_strlcpy(wrap, "WrapX", sizeof(wrap));
              }
            } else if (val & TF_OLD_WRAPY) {
              fc_strlcpy(wrap, "WrapY", sizeof(wrap));
            } else {
              fc_strlcpy(wrap, "", sizeof(wrap));
            }
 
            if (val & TF_ISO) {
              if (val & TF_HEX) {
                setting_bitwise_set(pset, "ISO|HEX", NULL, NULL, 0);
              } else {
                setting_bitwise_set(pset, "ISO", NULL, NULL, 0);
              }
            } else if (val & TF_HEX) {
              setting_bitwise_set(pset, "HEX", NULL, NULL, 0);
            } else {
              setting_bitwise_set(pset, "", NULL, NULL, 0);
            }
 
            setting_value_name(pset, FALSE, buf, sizeof(buf));
            secfile_replace_str(loading->file, buf,
                                "settings.set%d.value", i);
 
            secfile_insert_str(loading->file,
                               "wrap", "settings.set%d.name", set_count);
            secfile_insert_str(loading->file,
                               wrap, "settings.set%d.value", set_count);
 
            if (gamestart_valid) {
              if (secfile_lookup_enum_data(loading->file, &val, TRUE,
                                           setting_bitwise_secfile_str, &info,
                                           "settings.set%d.gamestart", i)) {
                if (val & TF_OLD_WRAPX) {
                  if (val & TF_OLD_WRAPY) {
                    fc_strlcpy(wrap, "WrapX|WrapY", sizeof(wrap));
                  } else {
                    fc_strlcpy(wrap, "WrapX", sizeof(wrap));
                  }
                } else if (val & TF_OLD_WRAPY) {
                  fc_strlcpy(wrap, "WrapY", sizeof(wrap));
                } else {
                  fc_strlcpy(wrap, "", sizeof(wrap));
                }
 
                if (val & TF_ISO) {
                  if (val & TF_HEX) {
                    setting_bitwise_set(pset, "ISO|HEX", NULL, NULL, 0);
                  } else {
                    setting_bitwise_set(pset, "ISO", NULL, NULL, 0);
                  }
                } else if (val & TF_HEX) {
                  setting_bitwise_set(pset, "HEX", NULL, NULL, 0);
                } else {
                  setting_bitwise_set(pset, "", NULL, NULL, 0);
                }
 
                setting_value_name(pset, FALSE, buf, sizeof(buf));
                secfile_replace_str(loading->file, buf,
                                    "settings.set%d.gamestart", i);
 
                secfile_insert_str(loading->file,
                                   wrap, "settings.set%d.gamestart", set_count);
              }
            }
 
            set_count++;
            count_changed = TRUE;
          }
        } else if (!fc_strcasecmp("alltemperate", name)) {
          alltemperate_idx = i;
        } else if (!fc_strcasecmp("singlepole", name)) {
          singlepole_idx = i;
        }
      }
 
      if (alltemperate_idx >= 0 || singlepole_idx >= 0) {
        int north_latitude, south_latitude;
        int north_idx, south_idx;
        bool alltemperate, singlepole;
 
        if (alltemperate_idx < 0
            || !secfile_lookup_bool(loading->file, &alltemperate,
                                    "settings.set%d.value",
                                    alltemperate_idx)) {
          /* Infer what would've been the ruleset default */
          alltemperate = (wld.map.north_latitude == wld.map.south_latitude);
        }
 
        if (singlepole_idx < 0
            || !secfile_lookup_bool(loading->file, &singlepole,
                                    "settings.set%d.value",
                                    singlepole_idx)) {
          /* Infer what would've been the ruleset default */
          singlepole = (wld.map.south_latitude >= 0);
        }
 
        /* Note: hard-coding 1000-based latitudes here; if MAX_LATITUDE ever
         * changes, that'll have to be handled in later migrations anyway */
        north_latitude = alltemperate ? 500 : 1000;
        south_latitude = alltemperate ? 500 : (singlepole ? 0 : -1000);
 
        /* Replace alltemperate with northlatitude, and singlepole with
         * southlatitude. If only one of the two was given, add the other
         * at the end. */
        north_idx = (alltemperate_idx < 0) ? set_count : alltemperate_idx;
        south_idx = (singlepole_idx < 0) ? set_count : singlepole_idx;
 
        secfile_replace_str(loading->file, "northlatitude",
                            "settings.set%d.name", north_idx);
        secfile_replace_int(loading->file, north_latitude,
                            "settings.set%d.value", north_idx);
 
        secfile_replace_str(loading->file, "southlatitude",
                            "settings.set%d.name", south_idx);
        secfile_replace_int(loading->file, south_latitude,
                            "settings.set%d.value", south_idx);
 
        if (gamestart_valid) {
          if (alltemperate_idx < 0
              || !secfile_lookup_bool(loading->file, &alltemperate,
                                      "settings.set%d.gamestart",
                                      alltemperate_idx)) {
            alltemperate =
                (wld.map.north_latitude == wld.map.south_latitude);
          }
 
          if (singlepole_idx < 0
              || !secfile_lookup_bool(loading->file, &singlepole,
                                      "settings.set%d.gamestart",
                                      singlepole_idx)) {
            singlepole = (wld.map.south_latitude >= 0);
          }
 
          north_latitude = alltemperate ? 500 : 1000;
          south_latitude = alltemperate ? 500 : (singlepole ? 0 : -1000);
 
          secfile_replace_int(loading->file, north_latitude,
                              "settings.set%d.gamestart", north_idx);
          secfile_replace_int(loading->file, south_latitude,
                              "settings.set%d.gamestart", south_idx);
        }
 
        if (alltemperate_idx < 0 || singlepole_idx < 0) {
          /* only one was given and replaced ~> we added one new entry */
          set_count++;
          count_changed = TRUE;
        }
      }
 
      if (count_changed) {
        secfile_replace_int(loading->file, set_count,
                            "settings.set_count");
      }
    }
  }
 
  {
    /* Turn old AI level field to a setting. */
    const char *level;
    enum ai_level lvl;
 
    level = secfile_lookup_str_default(loading->file, NULL, "game.level");
    if (level != NULL && !fc_strcasecmp("Handicapped", level)) {
      /* Up to freeciv-3.1 Restricted AI level was known as Handicapped */
      lvl = AI_LEVEL_RESTRICTED;
    } else {
      lvl = ai_level_by_name(level, fc_strcasecmp);
    }
 
    if (!ai_level_is_valid(lvl)) {
      log_sg("Invalid AI level \"%s\". "
             "Changed to \"%s\".", level,
             ai_level_name(GAME_HARDCODED_DEFAULT_SKILL_LEVEL));
      lvl = GAME_HARDCODED_DEFAULT_SKILL_LEVEL;
    }
 
    secfile_insert_str(loading->file, "ailevel", "settings.set%d.name", set_count);
    secfile_insert_enum(loading->file, lvl, ai_level, "settings.set%d.value", set_count);
 
    if (gamestart_valid) {
      secfile_insert_enum(loading->file, lvl, ai_level, "settings.set%d.gamestart",
                          set_count);
    }
 
    set_count++;
    secfile_replace_int(loading->file, set_count, "settings.set_count");
  }
 
  if (format_class != SAVEGAME_2) {
    /* Replace got_tech[_multi] bools on free_bulbs integers. */
    /* Older savegames had a bug that got_tech_multi was not saved. */
    count = secfile_lookup_int_default(loading->file, 0, "research.count");
    for (i = 0; i < count; i++) {
      bool got_tech = FALSE;
      int bulbs = 0;
      bool got_tech_multi
        = secfile_lookup_bool_default(loading->file, FALSE,
                                      "research.r%d.got_tech_multi", i);
 
      if (secfile_lookup_bool(loading->file, &got_tech,
                              "research.r%d.got_tech", i)
          && secfile_lookup_int(loading->file, &bulbs,
                                "research.r%d.bulbs", i)) {
        secfile_insert_int(loading->file,
                           got_tech || got_tech_multi ? bulbs : 0,
                           "research.r%d.free_bulbs", i);
      }
    }
  }
 
  /* Older savegames unnecessarily saved diplstate type order.
   * Silence "unused entry" warnings about those. */
  {
    int dscount = secfile_lookup_int_default(loading->file, 0,
                                             "savefile.diplstate_type_size");
 
    for (i = 0; i < dscount; i++) {
      (void) secfile_entry_lookup(loading->file,
                                  "savefile.diplstate_type_vector,%d", i);
    }
  }
 
  /* Add wl_max_length entries for players */
  {
    player_slots_iterate(pslot) {
      int plrno = player_slot_index(pslot);
      int ncities;
      int cnro;
      size_t wlist_max_length = 0;
      bool first_city;
 
      if (secfile_section_lookup(loading->file, "player%d", plrno) == NULL) {
        continue;
      }
 
      first_city = secfile_lookup_bool_default(loading->file, FALSE,
                                               "player%d.got_first_city",
                                               plrno);
      if (first_city) {
        const char **flag_names = fc_calloc(PLRF_COUNT, sizeof(char *));
        int flagcount = 0;
        const char **flags_sg;
        size_t nval;
 
        flag_names[flagcount++] = plr_flag_id_name(PLRF_FIRST_CITY);
 
        flags_sg = secfile_lookup_str_vec(loading->file, &nval,
                                          "player%d.flags", plrno);
 
        for (i = 0; i < nval; i++) {
          enum plr_flag_id fid = plr_flag_id_by_name(flags_sg[i],
                                                     fc_strcasecmp);
 
          flag_names[flagcount++] = plr_flag_id_name(fid);
        }
 
        secfile_replace_str_vec(loading->file, flag_names, flagcount,
                                "player%d.flags", plrno);
 
        free(flag_names);
      }
 
      ncities = secfile_lookup_int_default(loading->file, 0,
                                           "player%d.ncities", plrno);
 
      for (cnro = 0; cnro < ncities; cnro++) {
        int wl_length = secfile_lookup_int_default(loading->file, 0,
                                                   "player%d.c%d.wl_length",
                                                   plrno, cnro);
 
        wlist_max_length = MAX(wlist_max_length, wl_length);
 
        if (format_class == SAVEGAME_3) {
          if (secfile_lookup_int_default(loading->file, plrno,
                                         "player%d.c%d.original",
                                         plrno, cnro) != plrno) {
            secfile_insert_int(loading->file, CACQ_CONQUEST,
                               "player%d.c%d.acquire_t",
                               plrno, cnro);
          } else {
            secfile_insert_int(loading->file, CACQ_FOUNDED,
                               "player%d.c%d.acquire_t",
                               plrno, cnro);
          }
 
          secfile_insert_int(loading->file, WLCB_SMART,
                             "player%d.c%d.wlcb",
                             plrno, cnro);
        }
      }
 
      secfile_insert_int(loading->file, wlist_max_length,
                         "player%d.wl_max_length", plrno);
 
      if (format_class == SAVEGAME_3) {
        int nunits;
        int unro;
        size_t olist_max_length = 0;
 
        nunits = secfile_lookup_int_default(loading->file, 0,
                                            "player%d.nunits", plrno);
 
        for (unro = 0; unro < nunits; unro++) {
          int ol_length = secfile_lookup_int_default(loading->file, 0,
                                                     "player%d.u%d.orders_length",
                                                     plrno, unro);
 
          olist_max_length = MAX(olist_max_length, ol_length);
        }
 
        secfile_insert_int(loading->file, olist_max_length,
                           "player%d.orders_max_length", plrno);
 
        secfile_insert_int(loading->file, MAX_TRADE_ROUTES_OLD,
                           "player%d.routes_max_length", plrno);
      }
 
    } player_slots_iterate_end;
  }
}
 
/************************************************************************/
enum ai_level ai_level_convert(int old_level)
{
  switch (old_level) {
  case 1:
    return AI_LEVEL_AWAY;
  case 2:
    return AI_LEVEL_NOVICE;
  case 3:
    return AI_LEVEL_EASY;
  case 5:
    return AI_LEVEL_NORMAL;
  case 7:
    return AI_LEVEL_HARD;
  case 8:
    return AI_LEVEL_CHEATING;
  case 10:
#ifdef FREECIV_DEBUG
    return AI_LEVEL_EXPERIMENTAL;
#else  /* FREECIV_DEBUG */
    return AI_LEVEL_HARD;
#endif /* FREECIV_DEBUG */
  }
 
  return ai_level_invalid();
}
 
/************************************************************************/
enum barbarian_type barb_type_convert(int old_type)
{
  switch (old_type) {
  case 0:
    return NOT_A_BARBARIAN;
  case 1:
    return LAND_BARBARIAN;
  case 2:
    return SEA_BARBARIAN;
  }
 
  return barbarian_type_invalid();
}