K 10
svn:author
V 8
sveinung
K 8
svn:date
V 27
2015-10-15T03:12:20.847104Z
K 7
svn:log
V 1376
Mark actions with rare act sel dlg pop ups

A unit's ability to perform an action can cause the action selection dialog
to pop up before the player asks for it. It can happen when a unit is
transported into a city it is capable of performing an action to. It can
happen when a unit tries to move to a tile that has a target it may act
against.

This behavior isn't desirable for all actions. An action that can be
performed against almost every tile will annoy the user with a pop up each
time it moves. Being offered to do something dangerous is a situation where
it would be destructive can lead to the player's reflexes to accidentally
perform it.

Introduce the new action property rare_pop_up. A unit's ability to perform
an action where it is true will only pop up the action selection dialog
before the player asks for it in exceptional cases. At the moment that is
limited to the case when the player tries to move a unit to a tile it can't
move to but can perform the action to.

Have the rare_pop_up action property replace the special rules for when a
(potentially) legal action with a tile target can pop up the action
selection dialog.

Give the rare_pop_up action property to the actions "Explode Nuclear",
"Found City", "Join City" and "Recycle Unit".

Inspired by Marko Lindqvist <cazfi>'s "user_initiated" action property idea
in patch #6168.

See patch #6413
END