K 10
svn:author
V 8
wsimpson
K 8
svn:date
V 27
2008-03-09T15:59:40.001868Z
K 7
svn:log
V 505
(PR#40123) Crash when client tries global /observe

Never trust network data!  The client shouldn't crash with bad data.

The proximate cause of the crash is that client/packhand.c handle_conn_info()
is receiving an illegal 4th case: no playing pointer, but not an observer.

The ultimate cause appears to be /detach sending that bad combination.
Not fixed, awaiting other issues already in other tickets.

To make the future fix easier, added observing parameter to attach/detach
connection_to_player().

END